Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant circleci matrix parameter #993

Merged
merged 3 commits into from
Aug 17, 2020

Conversation

ffe4
Copy link
Contributor

@ffe4 ffe4 commented Aug 17, 2020

Description

Removes py38 from the matrix of the primary build job. Since python 3.8 has a separate build job, it does not need to be in the main matrix. Its inclusion results in the same tests being run twice.

Checklist:

  • Changelogs have been updated
  • Documentation has been updated

Since python 3.8 has a separate build job, it need not be in the matrix of the main build job.
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ffe4 ffe4 marked this pull request as ready for review August 17, 2020 15:25
@ffe4 ffe4 requested a review from a team August 17, 2020 15:25
@lzchen lzchen merged commit 5aa1d81 into open-telemetry:master Aug 17, 2020
@ffe4 ffe4 deleted the circleci-config branch August 17, 2020 16:12
@ffe4 ffe4 restored the circleci-config branch August 21, 2020 18:07
@ffe4 ffe4 deleted the circleci-config branch August 21, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants